DistributedPubSub: clearer logging when DeadLetter publishing due to no subscribers#7646
Conversation
…icate when there are no subscribers
…ss to clearly indicate no subscriber case in dead letter messages - Made DeadLetterWithNoSubscribers internal (class already existed) - Added test to verify dead letter messages are sent when no subscribers exist
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
Detailed my changes
There was a problem hiding this comment.
Trying out AMP code and this is the agent rules file for that
| var testMessage = "test-message"; | ||
|
|
||
| // act - publish to a topic that no one is subscribed to | ||
| await EventFilter.Info(contains: "DeadLetterWithNoSubscribers") |
There was a problem hiding this comment.
Validates that we get a more descriptive log message indicating that this message got DeadLetter'd because there were no subscribers
| // Use the specialized DeadLetterWithNoSubscribers class to clearly indicate | ||
| // that the message was not delivered because there were no subscribers, | ||
| // not because the mediator itself is dead. | ||
| var deadLetter = new DeadLetterWithNoSubscribers(message, Sender, Context.Self); |
There was a problem hiding this comment.
Uses the new custom dead letter type when we're routing messages to dead letters
| /// DeadLetters because there were no subscribers for the topic in DistributedPubSub, | ||
| /// NOT because the mediator itself is dead. | ||
| /// </summary> | ||
| internal sealed class DeadLetterWithNoSubscribers : AllDeadLetters |
There was a problem hiding this comment.
internal type, so no changes in public API
src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DeadLetterWithNoSubscribers.cs
Outdated
Show resolved
Hide resolved
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
Mentioned updates
| if (_settings.SendToDeadLettersWhenNoSubscribers) | ||
| Context.System.DeadLetters.Tell(new DeadLetter(message, Sender, Context.Self)); | ||
| { | ||
| var topic = message switch |
There was a problem hiding this comment.
Tries to extract the topic from the message so we can be as accurate as possible during the DeadLetter logging
| /// <returns>A string that represents the current object.</returns> | ||
| public override string ToString() | ||
| { | ||
| return $"DeadLetterWithNoSubscribers from {Sender} to {Recipient}: <{Message}> - No subscribers found for topic {Topic}"; |
There was a problem hiding this comment.
Topic should never actually be null - but that may change in the future if we start using IgnoreOrSendToDeadLetters for anything other than Send and Publish
Aaronontheweb
deleted the
feature/issue-7626-pubsub-dead-letter-clarification
branch
2 participants
Changes
Fix #7626: Using
DeadLetterWithNoSubscribersto clearly indicate when here are no subscribersChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
DeadLetterlogging when no subscribers looks identical to theMediatorbeing dead #7626