LogMessage GetProperties without FrozenDictionary#7968
Merged
Aaronontheweb merged 1 commit intoakkadotnet:devfrom Dec 17, 2025
Merged
LogMessage GetProperties without FrozenDictionary#7968Aaronontheweb merged 1 commit intoakkadotnet:devfrom
Aaronontheweb merged 1 commit intoakkadotnet:devfrom
Conversation
Aaronontheweb
approved these changes
Dec 17, 2025
| // Optimize: avoid ToArray() if Parameters() already returns IReadOnlyList | ||
| if (parameters is IReadOnlyList<object> readOnlyList) | ||
| { | ||
| _properties = CreatePropertyDictionary(PropertyNames, readOnlyList); |
Member
|
Tests that failed are some racy tests we still haven't managed to fix (the stress test one is particularly tricky) - unrelated to your PR. |
Arkatufus
pushed a commit
to Arkatufus/akka.net
that referenced
this pull request
Jan 7, 2026
Aaronontheweb
pushed a commit
that referenced
this pull request
Jan 8, 2026
This was referenced Jan 9, 2026
This was referenced Feb 11, 2026
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeating the optimization of not parsing PropertyNames when empty Parameters. See also #7960