Add service.name attribute to metrics#1048
Conversation
| metricsAttributes: | ||
| namespace: $NAMESPACE | ||
| binding: $BINDING | ||
| service.name: zilla |
There was a problem hiding this comment.
Let's not introduce this separate metricsAttributes property and instead define service.name in attributes.
Then in otlp exporter, metrics can filter global telemetry attributes for presence of service.name and include it if present, otherwise omit.
This will let us specify the service.name and have it included in the exported metrics attributes as needed to fix the bug in the otlp demo.
Separately, @vordimous will define a story about enhancing our support for telemetry exporter attributes.
There was a problem hiding this comment.
@jfallows @attilakreiner, here is the ticket to track the additional changes to the telemetry attributes. We haven't decided if a global telemetry.attributes section is needed or if just an individual options.attributes section on each exporter will be better. The ticket includes both so that a decision can be made after some more discovery around implementation.
Description
This change adds the telemetry attribute
service.nameto the metrics attributes in the open telemetry exporter.Fixes #1007