Fix failing test when JVM default locale is not US#1359
Merged
jfallows merged 1 commit intoaklivity:developfrom Mar 17, 2025
epieffe:develop
Merged
Fix failing test when JVM default locale is not US#1359jfallows merged 1 commit intoaklivity:developfrom epieffe:develop
jfallows merged 1 commit intoaklivity:developfrom
epieffe:develop
Conversation
jfallows
requested changes
Mar 13, 2025
...io/aklivity/zilla/runtime/exporter/prometheus/internal/printer/PrometheusMetricsPrinter.java
Outdated
Show resolved
Hide resolved
jfallows
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test PrometheusMetricsPrinterTest.shouldWorkWithMilliseconds() fails when the default JVM locale does not use dot (
.) as the decimal separator, because floating point numbers are formatted differently and the string comparison does not match.Solution: explicitly set the locale to
Locale.USwhen formatting decimal numbers. This makes the test pass regardless of the JVM locale settings and generally ensures more consistent behaviour because the output is independent from the JVM local configuration.