Set TCP flags appropriately to avoid Wireshark TCP dissector errors#1442
Merged
jfallows merged 5 commits intoaklivity:developfrom Apr 7, 2025
Merged
Set TCP flags appropriately to avoid Wireshark TCP dissector errors#1442jfallows merged 5 commits intoaklivity:developfrom
jfallows merged 5 commits intoaklivity:developfrom
Conversation
akrambek
previously approved these changes
Mar 29, 2025
akrambek
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wireshark complained about
ACK for unseen segmentcaused by early frames such asWINDOWarriving beforeSYN/SYN ACKcompleted in pseudo TCP handshake per Zilla bidirectional stream pair.Now we generate a complete (empty) TCP
SYN/SYN ACKand subsequent frame includesACKto complete the handshake implicitly.