Enforce worker capacity limit across both client and server tcp connections#1448
Merged
jfallows merged 7 commits intoaklivity:developfrom Apr 3, 2025
Merged
Conversation
jfallows
requested changes
Apr 3, 2025
| TcpConfiguration config, | ||
| EngineContext context) | ||
| { | ||
| this.capacity = new AtomicInteger(ENGINE_WORKER_CAPACITY.getAsInt(config)); |
Contributor
There was a problem hiding this comment.
This is not shared across cores, so doesn't need to be atomic.
Perhaps MutableInteger instead?
| final class TcpBindingContext implements BindingContext | ||
| { | ||
| private final Map<KindConfig, TcpStreamFactory> factories; | ||
| private final AtomicInteger capacity; |
Contributor
There was a problem hiding this comment.
This can just be a local variable, no need to store as a field, right?
Comment on lines
+91
to
+94
| if (capacity.get() <= 0) | ||
| { | ||
| //No capacity | ||
| } |
Contributor
There was a problem hiding this comment.
Label the try resolve: and then break resolve; if no capacity (instead of empty if-block).
jfallows
previously approved these changes
Apr 3, 2025
jfallows
approved these changes
Apr 3, 2025
jfallows
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.