Engine worker metrics support#1470
Merged
jfallows merged 20 commits intoaklivity:developfrom May 23, 2025
Merged
Conversation
jfallows
requested changes
May 20, 2025
|
|
||
| import org.agrona.collections.MutableInteger; | ||
|
|
||
| public final class CapacityTracker |
Contributor
There was a problem hiding this comment.
Suggested change
| public final class CapacityTracker | |
| public final class TcpCapacityTracker |
| { | ||
| MutableInteger capacity = new MutableInteger(ENGINE_WORKER_CAPACITY.getAsInt(config)); | ||
| LongConsumer capacityUsage = context.supplyUtilizationMetric(); | ||
| CapacityTracker capacity = new CapacityTracker(ENGINE_WORKER_CAPACITY.getAsInt(config), capacityUsage); |
Contributor
There was a problem hiding this comment.
Suggest passing config and context to TcpCapacityTracker and handling the metric lookup and the capacity lookup in the constructor.
Comment on lines
+174
to
+175
| for (SocketChannel channel = router.accept(server); channel != null; | ||
| channel = router.accept(server)) |
Contributor
There was a problem hiding this comment.
We can revert this change.
| { | ||
| // implicit int -> long conversion, it's OK | ||
| return labelResolver.apply(namespaceId); | ||
| return namespaceId != -1 ? labelResolver.apply(namespaceId) : null; |
Contributor
There was a problem hiding this comment.
Suggested change
| return namespaceId != -1 ? labelResolver.apply(namespaceId) : null; | |
| return namespaceId != NamespacedId.NO_NAMESPACE_ID ? labelResolver.apply(namespaceId) : null; |
| public String binding() | ||
| { | ||
| return labelResolver.apply(bindingId); | ||
| return bindingId != -1 ? labelResolver.apply(bindingId) : null; |
Contributor
There was a problem hiding this comment.
Suggested change
| return bindingId != -1 ? labelResolver.apply(bindingId) : null; | |
| return bindingId != NamespacedId.NO_LOCAL_ID ? labelResolver.apply(bindingId) : null; |
Comment on lines
+1
to
+7
| [ | ||
| { | ||
| "op": "add", | ||
| "path": "/$defs/telemetry/metrics/items/enum/-", | ||
| "value": "engine.worker.utilization" | ||
| } | ||
| ] |
Contributor
There was a problem hiding this comment.
I think we shouldn't need this to be configured, it should be always on, even for empty config, agree?
| '}' | ||
| '}]' | ||
| '}]' | ||
| '}]' |
Contributor
There was a problem hiding this comment.
Please restore the original formatting for readability.
| '}' | ||
| '}]' | ||
| '}]' | ||
| '}]' |
Contributor
There was a problem hiding this comment.
Please restore the original formatting for readability.
| NANOSECONDS, | ||
| COUNT | ||
| COUNT, | ||
| PERCENT |
Contributor
There was a problem hiding this comment.
Is it necessary to add a custom type here?
jfallows
requested changes
May 23, 2025
| public String binding() | ||
| { | ||
| return bindingId != -1 ? labelResolver.apply(bindingId) : null; | ||
| return bindingId != NamespacedId.NO_NAMESPACE_ID ? labelResolver.apply(bindingId) : null; |
Contributor
There was a problem hiding this comment.
Suggested change
| return bindingId != NamespacedId.NO_NAMESPACE_ID ? labelResolver.apply(bindingId) : null; | |
| return bindingId != NamespacedId.NO_LOCAL_ID ? labelResolver.apply(bindingId) : null; |
jfallows
previously approved these changes
May 23, 2025
jfallows
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1465