Add engine authorization config#1547
Merged
jfallows merged 17 commits intoaklivity:developfrom Sep 12, 2025
Merged
Conversation
jfallows
requested changes
Aug 29, 2025
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/EngineConfiguration.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Sep 2, 2025
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/EngineConfiguration.java
Outdated
Show resolved
Hide resolved
runtime/engine/src/test/java/io/aklivity/zilla/runtime/engine/test/EngineRule.java
Outdated
Show resolved
Hide resolved
...-http/src/main/java/io/aklivity/zilla/runtime/filesystem/http/internal/HttpWatchService.java
Outdated
Show resolved
Hide resolved
...ity/zilla/specs/engine/streams/application/reconfigure.create.via.http.basic.auth/client.rpt
Outdated
Show resolved
Hide resolved
bmaidics
commented
Sep 3, 2025
jfallows
requested changes
Sep 4, 2025
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/Engine.java
Outdated
Show resolved
Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/EngineConfiguration.java
Outdated
Show resolved
Hide resolved
...ain/java/io/aklivity/zilla/runtime/filesystem/http/internal/HttpFileSystemConfiguration.java
Outdated
Show resolved
Hide resolved
...em-http/src/main/java/io/aklivity/zilla/runtime/filesystem/http/internal/HttpFileSystem.java
Outdated
Show resolved
Hide resolved
...lesystem-http/src/main/java/io/aklivity/zilla/runtime/filesystem/http/internal/HttpPath.java
Outdated
Show resolved
Hide resolved
...-http/src/main/java/io/aklivity/zilla/runtime/filesystem/http/internal/HttpWatchService.java
Outdated
Show resolved
Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/Configuration.java
Outdated
Show resolved
Hide resolved
...ity/zilla/specs/engine/streams/application/reconfigure.create.via.http.basic.auth/server.rpt
Show resolved
Hide resolved
jfallows
requested changes
Sep 4, 2025
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/EngineConfiguration.java
Outdated
Show resolved
Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/EngineConfiguration.java
Show resolved
Hide resolved
jfallows
requested changes
Sep 5, 2025
...lesystem-http/src/main/java/io/aklivity/zilla/runtime/filesystem/http/internal/HttpPath.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Sep 9, 2025
Contributor
jfallows
left a comment
jfallows
left a comment
There was a problem hiding this comment.
Let's revert the changes to HttpFilesystemConfiguration including putting it back into .internal.
Then add a new class HttpFilesystemEnvironment which just has the 2 string constants on there instead of on HttpFilesystemConfiguration.
Then add a unit test to verify that the fully qualified environment constant names match the full names of the configuration properties.
Then when we need to configure the HttpFileSystem environment, we can use the constants from HttpFilesystemEnvironment in the exported package from filesystem-http module.
This reverts commit f000cfb.
jfallows
requested changes
Sep 9, 2025
runtime/engine/src/test/java/io/aklivity/zilla/runtime/engine/internal/ReconfigureHttpIT.java
Outdated
Show resolved
Hide resolved
...-http/src/main/java/io/aklivity/zilla/runtime/filesystem/http/HttpFilesystemEnvironment.java
Outdated
Show resolved
Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/Configuration.java
Show resolved
Hide resolved
...ain/java/io/aklivity/zilla/runtime/filesystem/http/internal/HttpFileSystemConfiguration.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Sep 12, 2025
jfallows
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.