Migrate engine started and stopped to telemetry events#1555
Merged
jfallows merged 11 commits intoaklivity:developfrom Sep 30, 2025
Merged
Migrate engine started and stopped to telemetry events#1555jfallows merged 11 commits intoaklivity:developfrom
jfallows merged 11 commits intoaklivity:developfrom
Conversation
bmaidics
commented
Sep 19, 2025
jfallows
requested changes
Sep 26, 2025
...rc/main/java/io/aklivity/zilla/runtime/command/start/internal/airline/ZillaStartCommand.java
Outdated
Show resolved
Hide resolved
...e/engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/EngineManager.java
Outdated
Show resolved
Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/Engine.java
Outdated
Show resolved
Hide resolved
...me/engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/EngineWorker.java
Outdated
Show resolved
Hide resolved
...e/engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/EngineManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/exporter/stdout/internal/StdoutExporterContext.java
Outdated
Show resolved
Hide resolved
...-stdout/src/test/java/io/aklivity/zilla/runtime/exporter/stdout/internal/events/EventIT.java
Outdated
Show resolved
Hide resolved
...in/scripts/io/aklivity/zilla/specs/exporter/stdout/system/stdout.system.namespace.patch.json
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Sep 30, 2025
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/Engine.java
Outdated
Show resolved
Hide resolved
| public void shouldLogEvents() throws Exception | ||
| { | ||
| k3po.start(); | ||
| Thread.sleep(1000); |
Contributor
There was a problem hiding this comment.
Can we remove the sleep now that we drain on close for exporter events?
Contributor
Author
There was a problem hiding this comment.
It is not needed for that. If we don't have the sleep, we immediately close the engine, not letting the handshake complete.
...-stdout/src/main/java/io/aklivity/zilla/runtime/exporter/stdout/internal/StdoutExporter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/exporter/stdout/internal/StdoutExporterHandler.java
Outdated
Show resolved
Hide resolved
...-stdout/src/test/java/io/aklivity/zilla/runtime/exporter/stdout/internal/events/EventIT.java
Outdated
Show resolved
Hide resolved
...rc/test/java/io/aklivity/zilla/runtime/exporter/stdout/internal/events/StdoutOutputRule.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Sep 30, 2025
.../src/main/java/io/aklivity/zilla/runtime/exporter/stdout/internal/StdoutExporterHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/exporter/stdout/internal/StdoutExporterHandler.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Sep 30, 2025
Contributor
There was a problem hiding this comment.
Suggested change
| private final SortedSet<StdoutExporterHandler> handlers; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1491