Mqtt kafka will message delivery#367
Merged
jfallows merged 20 commits intoaklivity:feature/mqtt-kafkafrom Aug 31, 2023
Merged
Conversation
jfallows
requested changes
Aug 17, 2023
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/client.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/client.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
bmaidics
commented
Aug 17, 2023
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
bmaidics
commented
Aug 17, 2023
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
6fca6e1 to
0193a0e
Compare
jfallows
requested changes
Aug 18, 2023
Contributor
jfallows
left a comment
There was a problem hiding this comment.
At the moment, we are modeling session stream abort and close as the same behavior, then special casing close with endEx to handle the different behaviors.
It feels like we are working too hard to get the effect, and could instead take advantage of abort (potentially send will message) vs close (do not send will message), and trigger those accordingly from mqtt binding on session stream.
Potentially no need for mqtt:endEx, use mqtt:abortEx instead if we want to convey exact error code, and close implies normal disconnect.
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/client.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/client.rpt
Outdated
Show resolved
Hide resolved
.../binding/mqtt/kafka/streams/kafka/session.will.message.close.deliver.will.message/client.rpt
Outdated
Show resolved
Hide resolved
.../binding/mqtt/kafka/streams/kafka/session.will.message.close.deliver.will.message/client.rpt
Outdated
Show resolved
Hide resolved
.../binding/mqtt/kafka/streams/kafka/session.will.message.close.deliver.will.message/client.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
...s/binding/mqtt/kafka/streams/kafka/session.will.message.abort.deliver.will.retain/server.rpt
Outdated
Show resolved
Hide resolved
0193a0e to
2fcafcd
Compare
bc438a7 to
8ad0ccc
Compare
jfallows
requested changes
Aug 28, 2023
...tt-kafka/src/main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/InstanceId.java
Outdated
Show resolved
Hide resolved
...tt-kafka/src/main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/InstanceId.java
Outdated
Show resolved
Hide resolved
...tt-kafka/src/main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/InstanceId.java
Outdated
Show resolved
Hide resolved
...ka/src/main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaBinding.java
Outdated
Show resolved
Hide resolved
.../main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaConfiguration.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Show resolved
Hide resolved
jfallows
requested changes
Aug 29, 2023
.../main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaConfiguration.java
Show resolved
Hide resolved
.../main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaConfiguration.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Aug 30, 2023
.../main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaConfiguration.java
Outdated
Show resolved
Hide resolved
.../main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaConfiguration.java
Outdated
Show resolved
Hide resolved
.../main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaConfiguration.java
Outdated
Show resolved
Hide resolved
...ava/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaBindingConfig.java
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionProxyIT.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Show resolved
Hide resolved
jfallows
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.