Skip to content

Mqtt kafka will message delivery#367

Merged
jfallows merged 20 commits intoaklivity:feature/mqtt-kafkafrom
bmaidics:mqtt_kafka_will
Aug 31, 2023
Merged

Mqtt kafka will message delivery#367
jfallows merged 20 commits intoaklivity:feature/mqtt-kafkafrom
bmaidics:mqtt_kafka_will

Conversation

@bmaidics
Copy link
Contributor

No description provided.

Copy link
Contributor

@jfallows jfallows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, we are modeling session stream abort and close as the same behavior, then special casing close with endEx to handle the different behaviors.

It feels like we are working too hard to get the effect, and could instead take advantage of abort (potentially send will message) vs close (do not send will message), and trigger those accordingly from mqtt binding on session stream.

Potentially no need for mqtt:endEx, use mqtt:abortEx instead if we want to convey exact error code, and close implies normal disconnect.

@bmaidics bmaidics marked this pull request as ready for review August 25, 2023 15:56
@bmaidics bmaidics changed the title Mqtt kafka will message scenarios Mqtt kafka will message delivery Aug 30, 2023
@jfallows jfallows merged commit 6b8ef76 into aklivity:feature/mqtt-kafka Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants