Inline Catalog#445
Merged
jfallows merged 2 commits intoaklivity:feature/schema-registryfrom Sep 22, 2023
Merged
Conversation
jfallows
requested changes
Sep 22, 2023
| "id", | ||
| "status" | ||
| ] | ||
| } No newline at end of file |
| type: inline | ||
| options: | ||
| subjects: | ||
| subject1: |
Contributor
There was a problem hiding this comment.
Perhaps we can use a sample from avro specification or similar?
If so, is there a logical associated name with the structure represented by the schema?
That would make the example more illustrative.
| #GENERATED_NOTICES# | ||
|
|
||
| This project also includes code under copyright of the following entities: | ||
| https://github.com/reaktivity/ No newline at end of file |
...ne/src/main/java/io/aklivity/zilla/runtime/catalog/inline/internal/InlineCatalogHandler.java
Show resolved
Hide resolved
| } | ||
| subjects.add(config); | ||
| return this; | ||
| } |
Contributor
There was a problem hiding this comment.
Need a subjects method taking a mapper, returning InlineSchemaConfigBuilder.
| InlineOptionsConfig catalog = new InlineOptionsConfig(singletonList( | ||
| new InlineSchemaConfig("subject1", "latest", | ||
| "{\"type\":\"object\",\"properties\":{\"id\":{\"type\":\"string\"},\"status\":{\"type\":\"string\"}}," + | ||
| "\"required\":[\"id\",\"status\"]}"))); |
jfallows
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #453