MQTT 3.1.1 support - specs#570
Merged
jfallows merged 6 commits intoaklivity:feature/mqtt-kafkafrom Nov 21, 2023
Merged
Conversation
jfallows
requested changes
Nov 15, 2023
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttClientFactory.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
This field does not need to change as it is local to the method, but the method name will need to change to decodeConnackV5 though.
Similar for other decode methods.
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
...test/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/server/v5/ConnectionIT.java
Outdated
Show resolved
Hide resolved
...ipts/io/aklivity/zilla/specs/binding/mqtt/streams/network/3.1.1/client.sent.abort/client.rpt
Outdated
Show resolved
Hide resolved
...vity/zilla/specs/binding/mqtt/streams/network/3.1.1/connect.successful.fragmented/client.rpt
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Nov 16, 2023
...rc/test/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/client/ConnectionIT.java
Show resolved
Hide resolved
...test/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/server/v5/ConnectionIT.java
Outdated
Show resolved
Hide resolved
.../specs/binding/mqtt/streams/network/v4/publish.one.message.subscribe.unfragmented/client.rpt
Show resolved
Hide resolved
jfallows
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.