Include validation in the openapi.http.proxy generator#586
Merged
jfallows merged 9 commits intoaklivity:developfrom Nov 28, 2023
Merged
Include validation in the openapi.http.proxy generator#586jfallows merged 9 commits intoaklivity:developfrom
openapi.http.proxy generator#586jfallows merged 9 commits intoaklivity:developfrom
Conversation
attilakreiner
commented
Nov 22, 2023
| this.schema = schema; | ||
| } | ||
|
|
||
| public String getType() |
Contributor
Author
There was a problem hiding this comment.
I am using jsonb for serialization. I didn't find a workaround to change the method names from get...(). The @JsonbProperty annotation seems to work only on methods that follow the naming convention.
jfallows
requested changes
Nov 27, 2023
...java/io/aklivity/zilla/runtime/command/generate/internal/openapi/OpenApiConfigGenerator.java
Outdated
Show resolved
Hide resolved
jfallows
reviewed
Nov 28, 2023
Contributor
jfallows
left a comment
jfallows
left a comment
There was a problem hiding this comment.
Let's keep our code clear of using the commons-collections transitive dependency.
Contributor
Author
Sure, done. |
jfallows
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include validation in the generate command in the
openapi.http.proxytemplateFixes #459