Skip invalid Kafka messages during Fetch#774
Merged
jfallows merged 4 commits intoaklivity:developfrom Feb 4, 2024
Merged
Conversation
jfallows
reviewed
Feb 1, 2024
Contributor
jfallows
left a comment
jfallows
left a comment
There was a problem hiding this comment.
Looks good, we just need to improve the log messages.
timestamp namespace.binding: Skipping invalid message on topic abc, partition N, offset M
?
jfallows
requested changes
Feb 2, 2024
Comment on lines
+518
to
+519
| System.out.println(String.format("%s %s: Skipping invalid message on topic %s, partition %d, offset %d", | ||
| System.currentTimeMillis(), bindingName, topic, id, offset)); |
Contributor
There was a problem hiding this comment.
Later, we're going to be logging to the EngineContext, and we usually don't pass strings around for bindings, just binding ids.
Let's change the method signature to put EngineContext and bindingId as the first 2 parameters. Note that bindingId is already there as routedId in KafkaCacheServerFetchFanout.
Suggested change
| System.out.println(String.format("%s %s: Skipping invalid message on topic %s, partition %d, offset %d", | |
| System.currentTimeMillis(), bindingName, topic, id, offset)); | |
| System.out.printf("%s:%s %s: Skipping invalid message on topic %s, partition %d, offset %d\n", | |
| System.currentTimeMillis(), context.supplyNamespace(bindingId), context.supplyLocalName(bindingId), topic, id, offset); |
Also, let's put these printfs inside conditional if based on EngineConfiguration.verbose().
jfallows
approved these changes
Feb 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.