zilla crash while using model-json and schema is not found#889
Merged
jfallows merged 2 commits intoaklivity:developfrom Apr 4, 2024
Merged
zilla crash while using model-json and schema is not found#889jfallows merged 2 commits intoaklivity:developfrom
jfallows merged 2 commits intoaklivity:developfrom
Conversation
jfallows
requested changes
Apr 2, 2024
Comment on lines
+79
to
+87
| if (provider != null) | ||
| { | ||
| in.wrap(buffer, index, length); | ||
| provider.createReader(in).readValue(); | ||
| } | ||
| else | ||
| { | ||
| status = false; | ||
| } |
Contributor
There was a problem hiding this comment.
Try to avoid using else clauses to assign boolean variables like this.
Instead, aim to take an approach that would also work for multiple conditions discovered incrementally.
Suggested change
| if (provider != null) | |
| { | |
| in.wrap(buffer, index, length); | |
| provider.createReader(in).readValue(); | |
| } | |
| else | |
| { | |
| status = false; | |
| } | |
| status &= provider != null; | |
| if (status) | |
| { | |
| in.wrap(buffer, index, length); | |
| provider.createReader(in).readValue(); | |
| } |
Comment on lines
+78
to
+88
| if (provider != null) | ||
| { | ||
| parser.next(); | ||
| parser = provider.createParser(in); | ||
| while (parser.hasNext()) | ||
| { | ||
| parser.next(); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| status = false; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (provider != null) | |
| { | |
| parser.next(); | |
| parser = provider.createParser(in); | |
| while (parser.hasNext()) | |
| { | |
| parser.next(); | |
| } | |
| } | |
| else | |
| { | |
| status = false; | |
| status &= provider != null; | |
| if (status) | |
| { | |
| in.wrap(buffer, index, length); | |
| provider.createReader(in).readValue(); | |
| } |
jfallows
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #817