Take 2 Global Settings and User Settings#248
Take 2 Global Settings and User Settings#248nhojpatrick wants to merge 1 commit intoaleksandr-m:masterfrom
Conversation
01f5b38 to
6dc1059
Compare
6dc1059 to
ad2458a
Compare
|
@aleksandr-m any thoughts about this PR, like the maven wrapper detection PR. It defines the variables the parent process automatically detected for |
ad2458a to
03d5e10
Compare
03d5e10 to
53f922c
Compare
53f922c to
26e1238
Compare
|
@aleksandr-m want to add you as a reviewer and request a review but don't have permissions to do that. |
26e1238 to
6669547
Compare
|
@aleksandr-m can this also be review and hopefully merged please. This and the other would result vm config and extra pom config. |
6669547 to
73d1779
Compare
|
+1, i hit the same problem when developing the ITs for #323 |
stefanseifert
left a comment
There was a problem hiding this comment.
it would be good to also add an integration test with custom maven settings.
i can help with this - or get inspiration from my PR #323 where i already had a use case to pass custom maven settings within an IT
src/main/java/com/amashchenko/maven/plugin/gitflow/AbstractGitFlowMojo.java
Show resolved
Hide resolved
src/main/java/com/amashchenko/maven/plugin/gitflow/AbstractGitFlowMojo.java
Show resolved
Hide resolved
aff19f6 to
c0648de
Compare
c0648de to
e8d1796
Compare
Another approach to #244
Adding
gitflow.maven.settings.globalandgitflow.maven.settings.useras plugin properties.If
-gsis already in theargLineit is skipped, same handling for-s.