Skip to content

Fix for parsing type strings for tuples containing static arrays of tuples#13

Merged
ahangsu merged 8 commits intoalgorand:mainfrom
ahangsu:tuple-array-bug-fix
Nov 29, 2022
Merged

Fix for parsing type strings for tuples containing static arrays of tuples#13
ahangsu merged 8 commits intoalgorand:mainfrom
ahangsu:tuple-array-bug-fix

Conversation

@ahangsu
Copy link
Copy Markdown
Contributor

@ahangsu ahangsu commented Nov 28, 2022

Fix #12

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #13 (1d1c5c2) into main (558c203) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   73.41%   73.66%   +0.24%     
==========================================
  Files           3        3              
  Lines         963      972       +9     
==========================================
+ Hits          707      716       +9     
  Misses        182      182              
  Partials       74       74              
Impacted Files Coverage Δ
abi/type.go 92.85% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahangsu
Copy link
Copy Markdown
Contributor Author

ahangsu commented Nov 28, 2022

seems that the CI codecov-upload is having some issue: codecov/codecov-action#598

need a few re-runs (3 times) to make codecov-upload work, flaky?

Comment thread abi/type.go
Comment thread abi/type.go Outdated
Comment thread abi/type.go Outdated
Comment thread abi/type.go
Comment thread abi/type_test.go
Comment thread abi/type.go
Copy link
Copy Markdown

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Comment thread abi/type_test.go Outdated
@ahangsu ahangsu merged commit 278bd82 into algorand:main Nov 29, 2022
@ahangsu ahangsu deleted the tuple-array-bug-fix branch November 29, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot parse type strings for tuples containing static arrays of tuples

4 participants