Merged
Conversation
…ate, remove the deprecated dry run mixins
…d... but still need the multidispatcher
* small typing fix + EncodingType * type ignores
1 task
added 2 commits
January 13, 2023 14:02
tzaffi
commented
Jan 13, 2023
| CREATION_APP_CALL: Final[int] = 0 | ||
| EXISTING_APP_CALL: Final[int] = 42 | ||
| @dataclass(frozen=True) | ||
| class DryRunTransactionParams: |
ahangsu
reviewed
Jan 13, 2023
tzaffi
commented
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>
ahangsu
reviewed
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
ahangsu
reviewed
Jan 17, 2023
Contributor
ahangsu
left a comment
ahangsu
left a comment
There was a problem hiding this comment.
generally looks good, I am going to take a final pass, if there's nothing off I notice, I will approve.
ahangsu
approved these changes
Jan 17, 2023
Contributor
ahangsu
left a comment
ahangsu
left a comment
There was a problem hiding this comment.
the last comment still holds, but once that is done, let's ship it.
This was referenced Jan 19, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff in
graviton/blackbox.pyis difficult to read through. Instead of looking at the diff, I encourage looking at the actual code. Additionally, this is a testing library, and therefore (IMO) we can gain most of the confidence by looking at the test results both here and in the companion pyteal PR.Former PR
#44
Issues Addressed
report()#38DryRunExecutor#40Summary of changes
graviton/blackbox.py:class DryRunTransactionParamsfor better grouping of some variablesclass DryRunExecutor:dryrun_*methods and consolidated functionality as follows:DryRunExecutorobject and callrun()on it. Convenience methodsrun_one()andrun_sequence()are also provided, and these have better type guarantees.*_test.pyandquadratic_factoring_game.ipynb- Migrating all the tests to userun_one()andrun_sequence()methods (except for the usage ofAbiContractExecutor.dry_run_on_sequence()which remains unaffected)tests/unit/encode_test.pytest_executor_inittest_executor_prepTODO's