Skip to content

Use of HashSet to filter out duplicates makes the order of foreign arrays unreliable #651

@CiottiGiorgio

Description

@CiottiGiorgio

https://github.com/algorand/java-algorand-sdk/blame/f3e6dcdfe24fefb455de52f1d07e1f83b25f6580/src/main/java/com/algorand/algosdk/builder/transaction/MethodCallTransactionBuilder.java#L108

As title. I recently helped a project debug an issue that was appearing at random times. We were able to track it down to the order of the accounts in the foreign account array. I believe this is not the only place that HashSet is being used as a filter but it's the only one that we were able to confirm.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions