ABI Interaction Support for JAVA SDK by ahangsu · Pull Request #268 · algorand/java-algorand-sdk

ahangsu · 2021-11-01T19:41:35Z

This PR enables developers to invoke on-chain contract methods using off-chain applications, as defined by ARC-0004 and following the design doc: https://gist.github.com/jasonpaulos/a810abe7e86d43840d14445718565a9a

Defines an object for an ABI method description and expose the signature and selector
Fix method signature parsing
Defines an object for an ABI interface description
Defines an object for an ABI contract description
TransactionSigner and other background types implementation
AtomicTransactionComposer implementation

closes #264

Test Plan

Cucumber test in ABI Json
Cucumber test in AtomicTransactionComposer

… call to go

…in cucumber

algochoi

Neat implementation!

algochoi · 2021-11-24T20:12:28Z

+
+    @Test
+    public void TestInterfaceClassMethods() throws IOException {
+        String testJSON = "{\"name\": \"Calculator\",\"methods\": [{ \"name\": \"add\", \"args\": [ { \"name\": \"a\", \"type\": \"uint64\", \"desc\": \"...\" },{ \"name\": \"b\", \"type\": \"uint64\", \"desc\": \"...\" } ] },{ \"name\": \"multiply\", \"args\": [ { \"name\": \"a\", \"type\": \"uint64\", \"desc\": \"...\" },{ \"name\": \"b\", \"type\": \"uint64\", \"desc\": \"...\" } ] }]}";


nit: Method objects now must have a returns field I think. This also applies to Methods in Contract.

The code here takes null and generates void return type on default. It seems to me that the implementation looks like the python one, which generates void when encountering null return from Json...

algochoi

Looks pretty good to me! Very minor nits

jasonpaulos

Pending tests, looks good!

(Resolved conflicts) commit ffc8254 Merge: 6e7cbec 7ae8485 Author: egieseke <eric_gieseke@yahoo.com> Date: Thu Dec 30 13:58:19 2021 -0500 Merge branch 'release/1.11.0-beta-2' into develop commit 7ae8485 Author: egieseke <eric_gieseke@yahoo.com> Date: Thu Dec 30 09:59:13 2021 -0500 bump to 1.11.0-beta-2 commit 6e7cbec Author: Hang Su <87964331+ahangsu@users.noreply.github.com> Date: Tue Dec 28 16:38:14 2021 -0500 Support Foreign objects as ABI arguments (#277) * update method/arg/returns/interface/contract definition * ugh no lambda in java7 * update method parsing, bug fix * update * update name checker and test cases * update testcase for method * update testing for contract and interface * update background types * update methods in atomic transaction composer * update methods in atomic transaction composer * update methods in atomic transaction composer, execute and add method call to go * need to update exed * update return value format * put method call option separate * update method, allowing argument to have tx type in string * update method list to map * update clone * update exec * update execute method * update params * yea this should break, add abijson test * update cucumber test for abijson * update cucumber test script * update * yea this one also fail cuz you need atomic transaction composer test in cucumber * there is a bug for transaction argument test, going to fix that * update minor fix to get through test * start working on integrate test for abi * resolve issues partly * working on integration test * make payment trans test in other class * half way through cucumber test * does not go through exec, dunno why * seeing some light ahead, compact the signedTxns with correct way * why returned log is empty? * minor renaming, and removing forced regex method name check * minor changes to rename stuffs and export stuffs * minor * minor * modify transactionSigner to an interface * minor update, update parse error in exec res * minor, return value cannot find abi res, do not throw exception * update sign method to sign interface hash code * update method arg ret with abitype, resolve build error * remove ABIValue and methodArgument * add method call polish * remove redundant lines * dirty fix for sdk not handling log return * update final step check, should pass... * change according to generator * updated naming * update naming * use generator again * minor * minor * resolve issues * start supporting foreign objects * update method test cases * supporting foreign array in atomic transaction composer * update compact foreign array, update array limit check, update method call allowing foreign array * update sender appid/addr to first apat/apas * minor * should be fixed * minor * first commit * update tuple wrapping mechanism, wrap from > 14 to > 15 * update contract appID to networks, should fail * minor * minor renaming * update cucumber test * clean up foreign object array support * minor * minor * minor on group size and group ID * revert test branch, get lost code back * update changes against cucumber test * update SDK testing implementation * resolve part of the review * remove some numerical constants by defining static final variables * minor * minor * optimize index to wait in execute * remove foreign object number constrain * per review * minor for ref type set * minor for contract networks non null * remove wildcard imports * minor * remove optimization on add method call commit 33652fe Author: Hang Su <87964331+ahangsu@users.noreply.github.com> Date: Wed Dec 8 16:39:02 2021 -0500 Upgrade `jackson` packages to resolve PRs on vulnerability update jackson-(core/databind/annotations) to resolve PR #279 and #229 commit b89681a Merge: 1c0e4f4 d398d0f Author: egieseke <eric_gieseke@yahoo.com> Date: Tue Dec 7 16:45:05 2021 -0500 Merge branch 'release/1.11.0-beta-1' into develop commit d398d0f Author: egieseke <eric_gieseke@yahoo.com> Date: Tue Dec 7 15:36:13 2021 -0500 Update Changelog. commit 2855578 Author: egieseke <eric_gieseke@yahoo.com> Date: Tue Dec 7 14:53:02 2021 -0500 Removed PRs for 267, 269, and 270 from Changelog. commit 8aa70c8 Author: egieseke <eric_gieseke@yahoo.com> Date: Tue Dec 7 11:34:00 2021 -0500 bump to 1.11.0-beta-1 commit 1c0e4f4 Author: Hang Su <87964331+ahangsu@users.noreply.github.com> Date: Fri Dec 3 13:49:24 2021 -0500 ABI Interaction Support for JAVA SDK (#268) This PR enables invoking on-chain contract methods using off-chain applications, as defined by ARC-0004. Design doc here: https://gist.github.com/jasonpaulos/a810abe7e86d43840d14445718565a9a commit 53b5583 Author: Hang Su <87964331+ahangsu@users.noreply.github.com> Date: Mon Nov 29 13:09:11 2021 -0500 Bug fix for `logs` on `PendingTransactionResponse` (#275) - update generator for new v2 model in java-sdk - add minor test for PendingTransactionResponse for retrieving logs commit 3086ecd Author: Hang Su <87964331+ahangsu@users.noreply.github.com> Date: Wed Nov 10 18:28:25 2021 -0500 Add WaitForConfirmation function (#274) Export WaitForConfirmation from test to SDK commit cf7248f Author: Will Winder <wwinder.unh@gmail.com> Date: Thu Oct 14 13:10:35 2021 -0400 Better error message on encoding exception. (#258) commit b830635 Author: Jason Paulos <jasonpaulos@users.noreply.github.com> Date: Tue Oct 12 13:29:04 2021 -0700 Revert "Revert "Fix ABI source code position for ABI feature (#260)"" This reverts commit 2bd5d77. commit 605bf4e Author: Jason Paulos <jasonpaulos@users.noreply.github.com> Date: Tue Oct 12 13:28:48 2021 -0700 Revert "Revert "Add ABI encoding support (#255)"" This reverts commit 1debe4e. commit b89da61 Merge: 04b497b cda8a83 Author: Jason Paulos <jasonpaulos@users.noreply.github.com> Date: Tue Oct 12 13:28:25 2021 -0700 Merge branch 'master' into develop commit 04b497b Merge: c488a10 c8f60e9 Author: Brice Rising <brice@algorand.com> Date: Tue Oct 12 15:26:53 2021 -0400 Merge branch 'release/1.10.0' into develop

ahangsu added 14 commits November 1, 2021 15:21

update method/arg/returns/interface/contract definition

efffc88

ugh no lambda in java7

ab31ad4

update method parsing, bug fix

9114cac

update

441cfca

update name checker and test cases

1b558c8

update testcase for method

0413e17

update testing for contract and interface

1ced8d7

update background types

06a3b11

update methods in atomic transaction composer

d6f1803

update methods in atomic transaction composer

e14c5af

update methods in atomic transaction composer, execute and add method…

80310b7

… call to go

need to update exed

eb0165d

update return value format

91a5b51

put method call option separate

ecd4cca

jasonpaulos mentioned this pull request Nov 10, 2021

Support foreign objects as ABI arguments #273

Closed

ahangsu added 12 commits November 10, 2021 13:57

update method, allowing argument to have tx type in string

d5d3007

Merge branch 'develop' into feature/abi-interaction

a18c360

update method list to map

43421fb

update clone

d3edf51

update exec

f1d561d

update execute method

f781b83

update params

18f5c51

yea this should break, add abijson test

aad02d4

update cucumber test for abijson

bf76701

update cucumber test script

b15865a

update

1a9a39a

yea this one also fail cuz you need atomic transaction composer test …

aa5cec6

…in cucumber

algochoi reviewed Nov 17, 2021

View reviewed changes

ahangsu added 2 commits November 17, 2021 15:57

there is a bug for transaction argument test, going to fix that

69a58fd

update minor fix to get through test

4bb9c8c

ahangsu added 10 commits November 22, 2021 13:50

minor update, update parse error in exec res

db0d1cc

minor, return value cannot find abi res, do not throw exception

df58750

update sign method to sign interface hash code

f2e4242

update method arg ret with abitype, resolve build error

0c73196

remove ABIValue and methodArgument

7301f0b

add method call polish

0d91dd4

remove redundant lines

f94433e

dirty fix for sdk not handling log return

c9af31b

update final step check, should pass...

54c0af2

change according to generator

2c4b970

ahangsu mentioned this pull request Nov 23, 2021

Bug fix for logs in Java-SDK algorand/generator#16

Merged

jasonpaulos mentioned this pull request Nov 23, 2021

ABI Interaction algorand/go-algorand-sdk#258

Merged

algochoi reviewed Nov 24, 2021

View reviewed changes

ahangsu added 6 commits November 29, 2021 00:38

updated naming

3b8f346

resolve conflict

3fd1ea9

update naming

5e7ee7e

use generator again

c4c7968

minor

b7370ed

minor

7c6ca51

algochoi reviewed Nov 29, 2021

View reviewed changes

Comment thread src/main/java/com/algorand/algosdk/transaction/AtomicTransactionComposer.java

Comment thread src/main/java/com/algorand/algosdk/transaction/AtomicTransactionComposer.java Outdated

resolve issues

7b539be

jasonpaulos reviewed Dec 2, 2021

View reviewed changes

ahangsu added 2 commits December 3, 2021 11:14

partly resolve reviews

4f9fd4a

partly resolve reviews

9ad5eaa

jasonpaulos approved these changes Dec 3, 2021

View reviewed changes

ahangsu merged commit 1c0e4f4 into develop Dec 3, 2021

ahangsu deleted the feature/abi-interaction branch December 3, 2021 18:51

egieseke mentioned this pull request Dec 7, 2021

bump to 1.11.0-beta-1 (for review only, do not merge) #278

Merged

onetechnical mentioned this pull request Jun 2, 2022

FOR REVIEW ONLY - java-algorand-sdk 1.15.0 #333

Merged

Conversation

ahangsu commented Nov 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Plan

Uh oh!

algochoi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

algochoi Nov 24, 2021

Choose a reason for hiding this comment

Uh oh!

ahangsu Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

algochoi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasonpaulos left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ahangsu commented Nov 1, 2021 •

edited

Loading

ahangsu Nov 29, 2021 •

edited

Loading