Merged
Conversation
algolucky
approved these changes
May 25, 2022
onetechnical
approved these changes
May 25, 2022
Contributor
onetechnical
left a comment
onetechnical
left a comment
There was a problem hiding this comment.
This looks good to me, but I also don't know how you test this. Maybe just wait for the next Java release?
algobarb
approved these changes
May 25, 2022
Contributor
algobarb
left a comment
algobarb
left a comment
There was a problem hiding this comment.
I assume we ultimately will need to add this config file to the gh-pages branch, right?
Contributor
Author
|
merging for now, will open another PR to copy circleci config into gh-pages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.