Enhancement: Migrate v1 algod dependencies to v2 in cucumber tests#425
Merged
Enhancement: Migrate v1 algod dependencies to v2 in cucumber tests#425
Conversation
ahangsu
changed the title
ahangsu
commented
Nov 15, 2022
ahangsu
force-pushed
the
remove-v1-tests
branch
12 times, most recently
from
58bec25 to
4615ec3
Compare
ahangsu
force-pushed
the
remove-v1-tests
branch
3 times, most recently
from
8bf4b62 to
44aa75a
Compare
ahangsu
force-pushed
the
remove-v1-tests
branch
from
44aa75a to
40afec2
Compare
ahangsu
force-pushed
the
remove-v1-tests
branch
from
32194ce to
9d0256e
Compare
algochoi
reviewed
Nov 22, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Nice work here, thanks for the efforts in updating v1 algod APIs - minor comments/questions below
ahangsu
force-pushed
the
remove-v1-tests
branch
2 times, most recently
from
8148210 to
643a5d6
Compare
algochoi
approved these changes
Nov 23, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Updated tests look good and it looks like it ran correctly in Circle CI - LGTM
Good to merge after changing the SDK testing branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates v1 algod usage in cucumber integration tests to use v2. Also deletes some unused steps relating to v1 APIs.
SDK Testing PR: algorand/algorand-sdk-testing#249