api: Regenerate Client Interfaces and implement cucumber tests.#555
Merged
api: Regenerate Client Interfaces and implement cucumber tests.#555
Conversation
winder
commented
Apr 26, 2023
Comment on lines
+39
to
+41
| public String getRequestMethod() { | ||
| return httpMethod.method(); | ||
| } |
winder
changed the title
ahangsu
approved these changes
Apr 26, 2023
Contributor
ahangsu
left a comment
ahangsu
left a comment
There was a problem hiding this comment.
looks good on Simulate* side
Contributor
|
I think we need to regenerate the models based on algorand/go-algorand#5335 |
Contributor
Author
Thanks, my local algod repo was stale. Regenerated with the current master and it picked up several changes. |
algochoi
approved these changes
Apr 26, 2023
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Looks good - noting that the simulation endpoints are only generated and not tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for where the auto-pr ends and my changes begin.
This uses and updated generator.
generator PR: algorand/generator#61
codegen diff: 4453df9