Test identical functionality across versions by tzaffi · Pull Request #605 · algorand/pyteal

tzaffi · 2022-11-15T01:52:40Z

Summary of changes

Use Graviton's new capability (Graviton #36) for asserting that two separate teal programs behave exactly the same relative a set of invariants to test v8 versions (with frame pointers) vs. v6 (without).

Graviton Dependency

Graviton #36 should be merged in first
Graviton #42 should be merged in first
And the graviton dependency point to v0.7.0
NO! ~~Shall we merge in the following first?~~
- ~~Refactor graviton usage #628 into this PR~~
- ~~Graviton #44~~

* adding program page related ops

* Add Replace * Remove replace auto-import * Use scripts/generate_init.py * Add more tests to replace, substring, and extract (#1) Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* Add Block # Conflicts: # pyteal/ir/ops.py * Disable flake8 errors on formatted lines * Add past version failure check * Remove unnecessary ignore Expr equality context

* Add JsonRef * Use named class methods to specify value type * Remove unnecessary ignore Expr equality context * Fix docstring link

* Add Base64Decode * Remove unnecessary ignore Expr equality context

* Support Secp256r1 curve * Fix type errors in ecdsa tests * Fix typo * Test Secp256k1 curve against TEAL 5 instead * Add compile check to `MultiValue` class * Use `MultiValue` compile checks instead of inheritance

* Add VrfVerify # Conflicts: # pyteal/ast/__init__.py # pyteal/ir/ops.py * Tidy with `MultiValue`’s compile check

* Add sha3_256 * Add crypto docs

* Add first valid time factory and update min version * Include FirstValidTime in txn tests * Add transaction field docs

* Add ed25519verify_bare * Fix typos in Ed25519 docstrings (#2) * Add crypto doc for Ed25519Verify_Bare Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* add box ops * full support on ops * first set of test, add versioning in multi * remove some seemingly not necessary code? * update testcase * check invalid arguments * finish testcase * move stuffs to app * version check trick * verifyTealVersion apply * error message * update docs structures * period * update doc * update doc * update doc * per pr review on implementation * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * hex box size goes wild * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * warning about MBR * wording * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * emphasize * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * polishing * remove redundant box_put doc segment * per zeph pr review * use note and warning * per zeph's pr review * Update docs/state.rst Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * creating boxes * Update docs/state.rst Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * per pr review * table for state types Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* swapping base64 modes to match the rest (#446) * Merge master into teal7 (#450) * AVM 7: Address integration branch feedback (#452) * Add Execute Method (#444) * adding execute method to allow omission of begin/submit for common use case * exec docstring * update testcase Co-authored-by: Hang Su <hang.su@algorand.com> * Merge branch 'master' into teal7 (#463) * fix misspelling of uint (#431) * fix misspelling of uint * Clarify minimum Python version management docs (#435) * Foreign prefix on App and Asset arrays (#440) * replacing foreignapps with applications * fix assets as well * Add Execute Method (#444) * adding execute method to allow omission of begin/submit for common use case * exec docstring * update testcase Co-authored-by: Hang Su <hang.su@algorand.com> Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Hang Su <hang.su@algorand.com> * Consolidate TEAL and AVM versioning (#441) * fix misspelling of uint (#431) * fix misspelling of uint * Clarify minimum Python version management docs (#435) * Convert TEAL version references to program version by hand * Replace `teal#Options` with `avm#Options` * Deprecate `*_TEAL_VERSION` in favor of `*_PROGRAM_VERSION` * Fix docs typo Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * Minor `versions.rst` changes * Fix `verifyTealVersion` in new opcode files * Fix linter errors * Fix language discrepencies introduced by the merge * Remove incorrect avm replacement * Fix inconsistent language introduced by merge Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * max program version Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Jacob Daitzman <jdtzmn@gmail.com>

…/files (#488)

Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>

…/out frame pointers

tzaffi · 2022-12-27T16:34:44Z

-                abi_argument_types=self.abi_argument_types(),
-                abi_return_type=self.abi_return_type(),
+                abi_method_signature=self.abi_method_signature(),
+                omit_method_selector=True,


The parameters abi_argument_types and abi_return_type are removed from graviton's DryRunExecutor in favor of abi_method_signature

tzaffi · 2022-12-27T16:36:59Z

    case_name = subr.name()
    print(f"stable TEAL generation test for {case_name} in mode {mode}")

+    # HANG NOTE: I prefer not to modify this test, for it is skipped now on thread-unsafe behavior,


I wonder if this test now passes under frame pointers? But I haven't yet tried.

tzaffi · 2022-12-27T16:37:42Z

        # since only a single input, just assert a constant in each case
        "assertions": {
-            DRProp.cost: 11,
+            DRProp.cost: lambda _, actual: actual in {11, 12},


This change (and other similar) is to accommodate running both v6 and v8 (frame pointers) which result in slight differences.

tzaffi · 2022-12-27T16:39:03Z

    oldfac: {
        "inputs": [(i,) for i in range(25)],
        "assertions": {
-            DRProp.cost: lambda args, actual: (


In several cases, I completely removed assertions. I'm confident that we're good-to-go though because of the new "identities" tests.

tzaffi · 2022-12-27T16:43:39Z

+    Invariant.full_validation(
+        APP_IDENTICAL_PREDICATES,
+        inspectors=inspectors6,
+        identities=inspectors8,


Here are new "identities" tests in a action.

See also lines:

462

467

559

609

615

782

793

904

910

960

966

1091

1102

tzaffi · 2023-01-01T17:37:43Z

@@ -144,8 +144,14 @@ def decorator_blackbox(func: SubroutineFnWrapper | ABIReturnSubroutine):

 @dataclass(frozen=True)
 class _MatchMode(Generic[Output]):


FYI: #628 completely eliminates _MatchMode

tzaffi · 2023-01-01T17:41:29Z


+        self.traces: list = []
+
+    def add_trace(self, trace: Any) -> None:


This is removed in #628

tzaffi · 2023-01-03T22:36:40Z

    :language: python

-As shown in this exmaple, the logic of smart contract is expressed using PyTeal expressions constructed in Python. PyTeal overloads Python's arithmetic operators 
+As shown in this example, the logic of smart contract is expressed using PyTeal expressions constructed in Python. PyTeal overloads Python's arithmetic operators 


bad rebase causing this already existing change to appear as changing

michaeldiamant

@tzaffi Looks ready to me - I primarily focused my review on tests/integration/graviton_test.py. The remaining enabled assertions seem reasonable.

I can imagine wanting to split assertions by compiled version because there are significant differences between <= v7 and >= v8. However, it's not worth holding the PR.

tzaffi · 2023-01-11T16:04:11Z

@tzaffi Looks ready to me - I primarily focused my review on tests/integration/graviton_test.py. The remaining enabled assertions seem reasonable.

I can imagine wanting to split assertions by compiled version because there are significant differences between <= v7 and >= v8. However, it's not worth holding the PR.

I'm going to merge but I do want to follow up and understand this concern a bit better and possibly create a new issue.

barnjamin and others added 30 commits June 24, 2022 10:05

upping max teal version

d0f9d8d

adding program page related ops (#412)

749fb8c

* adding program page related ops

Add Replace (#413)

39a11c2

* Add Replace * Remove replace auto-import * Use scripts/generate_init.py * Add more tests to replace, substring, and extract (#1) Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

Add Block (#415)

dd2c7ec

* Add Block # Conflicts: # pyteal/ir/ops.py * Disable flake8 errors on formatted lines * Add past version failure check * Remove unnecessary ignore Expr equality context

Add JsonRef (#417)

8c3d2a0

* Add JsonRef * Use named class methods to specify value type * Remove unnecessary ignore Expr equality context * Fix docstring link

Add Base64Decode (#418)

839b985

* Add Base64Decode * Remove unnecessary ignore Expr equality context

Support Secp256r1 curve (#423)

7cccdcb

* Support Secp256r1 curve * Fix type errors in ecdsa tests * Fix typo * Test Secp256k1 curve against TEAL 5 instead * Add compile check to `MultiValue` class * Use `MultiValue` compile checks instead of inheritance

Add VrfVerify (#419)

9a26fec

* Add VrfVerify # Conflicts: # pyteal/ast/__init__.py # pyteal/ir/ops.py * Tidy with `MultiValue`’s compile check

Add Sha3_256 (#425)

cc544aa

* Add sha3_256 * Add crypto docs

Support FirstValidTime transaction field (#424)

6e83ae6

* Add first valid time factory and update min version * Include FirstValidTime in txn tests * Add transaction field docs

Add Ed25519Verify_Bare (#426)

594e8e4

* Add ed25519verify_bare * Fix typos in Ed25519 docstrings (#2) * Add crypto doc for Ed25519Verify_Bare Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

Merge branch 'master' into avm8

0ba95e9

Merge branch 'master' into avm8

e9af25f

Merge branch 'master' into avm8

ed516f7

change according to https://github.com/algorand/go-algorand/pull/4323…

055c981

…/files (#488)

Merge branch 'master' into avm8-merge-master

bc78e39

Merge branch 'master' into avm8

2c2b7b2

Merge branch 'master' into avm8

61af648

Merge branch 'master' into avm8

5282726

Changes to avm8 docs (#546)

76010b2

Merge branch 'master' into avm8

d767c66

Support new AVM 8 account parameters (#555)

cc49a55

add frame ops to avm8 branch

1d7cd6a

specify FRAME_POINTER_VERSION in frame-op branch

49d169e

just the work of abi data schema

02f3775

squashed

e8c5d2c

change in round trip test, stop something blocking me

a044f80

update frame dig and proto use

6739c00

ahangsu reviewed Dec 13, 2022

View reviewed changes

Comment thread requirements.txt Outdated

Update requirements.txt

4d45f09

Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>

ahangsu mentioned this pull request Dec 16, 2022

Add a missing arg for method sig in OpUp integration test #617

Closed

michaeldiamant and others added 3 commits December 22, 2022 09:42

Prove no assertions tested

5b4ae33

Merge branch 'master' into graviton-identical-subroutines

669b202

Merge branch 'broken_invariants' into graviton-identical-subroutines

2dc41da

tzaffi mentioned this pull request Dec 22, 2022

Prevent blackbox_test_runner from passing without invariant assertions #621

Closed

Zeph Grunschlag added 2 commits December 22, 2022 20:00

get the tests to actually run, and nudge invariants to pass both with…

3b20a21

…/out frame pointers

absorb the new graviton API

6e7889d

tzaffi commented Dec 24, 2022

View reviewed changes

Comment thread tests/integration/graviton_test.py

tzaffi commented Dec 24, 2022

View reviewed changes

Comment thread tests/integration/graviton_test.py

Zeph Grunschlag added 2 commits December 23, 2022 20:35

Merge branch 'master' into graviton-identical-subroutines

cf9ced7

update graviton's pin to latest branch commit

d8bd2db

tzaffi commented Dec 27, 2022

View reviewed changes

Comment thread requirements.txt Outdated

tzaffi commented Dec 27, 2022

View reviewed changes

tzaffi commented Jan 1, 2023

View reviewed changes

tzaffi and others added 2 commits January 3, 2023 16:29

pin to v0.7.0

0ee255c

Typo fix in docs (#625)

ed1baf4

tzaffi commented Jan 3, 2023

View reviewed changes

Zeph Grunschlag added 2 commits January 11, 2023 09:33

Merge branch 'master' into graviton-identical-subroutines

c30bf74

Merge branch 'master' into graviton-identical-subroutines

3fc48d6

michaeldiamant approved these changes Jan 11, 2023

View reviewed changes

tzaffi merged commit dc6466a into master Jan 11, 2023

tzaffi deleted the graviton-identical-subroutines branch January 11, 2023 16:04

		@@ -144,8 +144,14 @@ def decorator_blackbox(func: SubroutineFnWrapper \| ABIReturnSubroutine):

		@dataclass(frozen=True)
		class _MatchMode(Generic[Output]):


		self.traces: list = []

		def add_trace(self, trace: Any) -> None:

Conversation

tzaffi commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Graviton Dependency

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tzaffi Dec 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaeldiamant left a comment

Choose a reason for hiding this comment

Uh oh!

tzaffi commented Jan 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tzaffi commented Nov 15, 2022 •

edited

Loading

tzaffi Dec 27, 2022 •

edited

Loading