FilterNamespaceBlack db.collection support for transactions

[garaghav7]

We tested the following scenario

1. testdb.coll1 is added to FilterNamespaceBlack[] configuration
2. Created a transaction which includes testdb.coll1 and testdb.coll2 and committed the transaction
3. Noticed that testdb.coll1 is replicated on passive mongo cluster even though it was added in the blacklist.

Please confirm the above behavior.
If FilterNamespaceBlack of db.collection is supported for transactions or there are any limitations around this?

Thanks

[mehar]

This test seems to fail as well as expected

MongoShake/collector/filter/filter_test.go

Line 142 in acbaf60

filter := NewNamespaceFilter(nil, []string{"ff"})

[garaghav7]

We noticed the commit that caused this testcase to fail is this one - 3256d5d
The code that handles the namespace filter for transactions is commented. Was this intentional ?

The tag 2.7.4 which was released before this commit has the test passing.
Please confirm if we can raise a PR for this?

Thanks
Gayathri

[mehar]

Any thoughts on this from the committers?

[zhongli-james]

Any thoughts on this from the committers?

So sorry for the late reply. From the description of the committer, it is to improve the processing performance of the transaction oplog during incr sync stage. As you can see in diff, the logic of *NamespaceFilter.Filter() has been greatly simplified, so that filter now does not filter txn operations. Also there is TODO in *Batch.BatchMore().
Plz kindly let me know if v2.7.4 could fix your concern or you want this feat on latest version.

Please confirm if we can raise a PR for this?

Always welcomed, we may discuss the implementation later in PR.

[zhongli-james]

BTW, i will fix the test file later. (We always expect all unit tests to work properly)

[zhongli-james]

will be fixed in release v2.8.6.