Skip to content

optimize: update checkStyle version#13914

Merged
KomachiSion merged 5 commits intoalibaba:developfrom
WangzJi:feat/update-checkstyle-version
Nov 4, 2025
Merged

optimize: update checkStyle version#13914
KomachiSion merged 5 commits intoalibaba:developfrom
WangzJi:feat/update-checkstyle-version

Conversation

@WangzJi
Copy link
Contributor

@WangzJi WangzJi commented Oct 31, 2025

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

closes: #13796

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@github-actions
Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@WangzJi WangzJi marked this pull request as draft October 31, 2025 08:22
KomachiSion
KomachiSion previously approved these changes Nov 3, 2025
@KomachiSion
Copy link
Collaborator

@WangzJi 有个文件有冲突, 麻烦解决一下

# Conflicts:
#	ai/src/test/java/com/alibaba/nacos/ai/service/McpServerTransformServiceTest.java
@WangzJi WangzJi marked this pull request as ready for review November 3, 2025 03:44
@KomachiSion
Copy link
Collaborator

@WangzJi 好像修改了之后, 有checkstyle无法通过的问题

@WangzJi
Copy link
Contributor Author

WangzJi commented Nov 4, 2025

https://github.com/alibaba/nacos/blob/39a55482912c52e373009f652635d4588fb8d860/client/src/main/java/com/alibaba/nacos/client/config/impl/ConfigFuzzyWatchGroupKeyHolder.java#L112C9-L114C11

this.loginScheduledExecutor =
Executors.newSingleThreadScheduledExecutor(new NameThreadFactory("com.alibaba.nacos.client.login-executor"));
this.loginScheduledExecutor.scheduleWithFixedDelay(() -> securityProxy.login(properties), 0,
this.securityInfoRefreshIntervalMills, TimeUnit.MILLISECONDS);

The code in this PR does not modify this part, so I’m not sure why the PMD failure is showing up.

@KomachiSion
Copy link
Collaborator

应该是#13878 这个pr引入的,之前合并的时候不知道为什么没跑出来。

帮忙先加个忽略标签跳过一下。

@SuppressWarnings("PMD.ThreadPoolCreationRule")

这两个报警的方法上都加一下

@KomachiSion
Copy link
Collaborator

McpServerTransformServiceTest.java

似乎有很多测试不通过的, 我用develop分支跑是可以通过的

@wuyfee
Copy link

wuyfee commented Nov 4, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
❌ - deploy (standalone & cluster & standalone_auth): failure
❌ - e2e-java-test (standalone & cluster & standalone_auth): skipped
❌ - e2e-go-test (standalone & cluster): skipped
❌ - e2e-cpp-test (standalone & cluster): skipped
❌ - e2e-csharp-test (standalone & cluster): skipped
❌ - e2e-nodejs-test (standalone & cluster): skipped
❌ - e2e-python-test (standalone & cluster): skipped
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link

wuyfee commented Nov 4, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
❌ - deploy (standalone & cluster & standalone_auth): failure
❌ - e2e-java-test (standalone & cluster & standalone_auth): skipped
❌ - e2e-go-test (standalone & cluster): skipped
❌ - e2e-cpp-test (standalone & cluster): skipped
❌ - e2e-csharp-test (standalone & cluster): skipped
❌ - e2e-nodejs-test (standalone & cluster): skipped
❌ - e2e-python-test (standalone & cluster): skipped
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion added this to the 3.1.1 milestone Nov 4, 2025
@KomachiSion KomachiSion merged commit 24cc216 into alibaba:develop Nov 4, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Checkstyle to support Java 17

3 participants