Skip to content

[ISSUE #13964] Fix when nacos.extension.ai.enabled is false, nacos start fa…#13965

Merged
KomachiSion merged 2 commits intoalibaba:developfrom
aihai:fix-when-ai-disabled-nacos-start-failed
Nov 26, 2025
Merged

[ISSUE #13964] Fix when nacos.extension.ai.enabled is false, nacos start fa…#13965
KomachiSion merged 2 commits intoalibaba:developfrom
aihai:fix-when-ai-disabled-nacos-start-failed

Conversation

@aihai
Copy link
Contributor

@aihai aihai commented Nov 25, 2025

…iled.

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#13964

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

KomachiSion
KomachiSion previously approved these changes Nov 25, 2025
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Nov 25, 2025
@KomachiSion KomachiSion added this to the 3.1.1 milestone Nov 25, 2025
@KomachiSion
Copy link
Collaborator

CI not pass, please fix it.

@aihai
Copy link
Contributor Author

aihai commented Nov 25, 2025

Fixed it, 3x.
But test failed, it worked on my local.

@wuyfee
Copy link

wuyfee commented Nov 25, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
❌ - deploy (standalone & cluster & standalone_auth): failure
❌ - e2e-java-test (standalone & cluster & standalone_auth): skipped
❌ - e2e-go-test (standalone & cluster): skipped
❌ - e2e-cpp-test (standalone & cluster): skipped
❌ - e2e-csharp-test (standalone & cluster): skipped
❌ - e2e-nodejs-test (standalone & cluster): skipped
❌ - e2e-python-test (standalone & cluster): skipped
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion
Copy link
Collaborator

Will re-run ci.

@KomachiSion KomachiSion merged commit 3e3beb0 into alibaba:develop Nov 26, 2025
3 of 5 checks passed
@aihai aihai deleted the fix-when-ai-disabled-nacos-start-failed branch November 26, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants