【summer_issue#8313】Ecological Construction and optimization of NACOS Service Mesh#9158
Conversation
…e update design of the data layer、Debounce、CDE, EDS, incremental EDS, incremental MCP.
SpecialYang
left a comment
SpecialYang
left a comment
There was a problem hiding this comment.
Please remove irrelative code changes. And remove v2 support and empty generator for CDS/EDS.
istio/src/main/java/com/alibaba/nacos/istio/api/ApiConstants.java
Outdated
Show resolved
Hide resolved
istio/src/main/java/com/alibaba/nacos/istio/api/ApiConstants.java
Outdated
Show resolved
Hide resolved
istio/src/main/java/com/alibaba/nacos/istio/api/ApiConstants.java
Outdated
Show resolved
Hide resolved
istio/src/main/java/com/alibaba/nacos/istio/api/ApiConstants.java
Outdated
Show resolved
Hide resolved
istio/src/main/java/com/alibaba/nacos/istio/common/AbstractConnection.java
Outdated
Show resolved
Hide resolved
RocketEngine26
changed the title
istio/src/main/java/com/alibaba/nacos/istio/xds/NacosXdsService.java
Outdated
Show resolved
Hide resolved
istio/src/main/java/com/alibaba/nacos/istio/xds/NacosXdsService.java
Outdated
Show resolved
Hide resolved
istio/src/main/java/com/alibaba/nacos/istio/model/PushContext.java
Outdated
Show resolved
Hide resolved
istio/src/main/java/com/alibaba/nacos/istio/api/ApiGenerator.java
Outdated
Show resolved
Hide resolved
| //TODO: service data change event, instance event | ||
| result.add(ClientOperationEvent.ClientRegisterServiceEvent.class); | ||
| result.add(ClientOperationEvent.ClientDeregisterServiceEvent.class); | ||
| result.add(InfoChangeEvent.ServiceInfoChangeEvent.class); |
There was a problem hiding this comment.
What's the difference between ServiceInfoChangeEvent and ServiceMetadataEvent ?
There was a problem hiding this comment.
The ServiceMetadataEvent is used primarily to determine whether metadata is out of date and can not determine changes to data such as weights
| private int mcpPushInterval; | ||
|
|
||
| @Value("${nacos.istio.server.full:true}") | ||
| private boolean fullEnabled = true; |
There was a problem hiding this comment.
What is the this param does for?
There was a problem hiding this comment.
determine whether to use Delta
There was a problem hiding this comment.
But this param never be used. consider to remove it.
There was a problem hiding this comment.
This parameter is used in incremental push. If the server does not agree to incremental push even if the client support, incremental push can not be carried out
SpecialYang
left a comment
SpecialYang
left a comment
There was a problem hiding this comment.
Two tips need to be fixed.
| } | ||
| } | ||
|
|
||
| private void init() { |
There was a problem hiding this comment.
When do we execute init?
There was a problem hiding this comment.
In the Watcher, the code has been modified
| private int mcpPushInterval; | ||
|
|
||
| @Value("${nacos.istio.server.full:true}") | ||
| private boolean fullEnabled = true; |
There was a problem hiding this comment.
But this param never be used. consider to remove it.
…Service Mesh (alibaba#9158) * Change the polling mechanism to listen for event changes;Implement the update design of the data layer、Debounce、CDE, EDS, incremental EDS, incremental MCP. * Remove unnecessary changes and logs * Simplify the code * Simplify * Add the delta API description * Fixed a bug * Update application.properties * Modify the event merge mechanism; remove unnecessary classes * Initialize
3 participants
What is the purpose of the change
Design Nacos support XDS protocol design document, and complete the module development;
Aiming at the performance problem of full push between Nacos and Istio, the incremental push method is used to optimize the design
Add the corresponding documentation for the service grid ecology to the NACOS official documentation.
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily: