[sfm] statistics: fix statistics to avoid troubles in particular cases #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
servantftransperfect
left a comment
servantftransperfect
left a comment
There was a problem hiding this comment.
All the outStats.max values are not checked for a value of 0, which may create a +inf result in histogram constructor. Although this is not realistic, this may happen in tests and also (rarely) in "computeScaleHistogram".
servantftransperfect
force-pushed
the
fix/sfmStats
branch
from
086455d to
4254cb1
Compare
servantftransperfect
force-pushed
the
fix/sfmStats
branch
from
4254cb1 to
3b164fa
Compare
Contributor
|
I modified the code to clamp on both sides of range. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular configuration, like a failed resection, we may end-up with unexpected statistics.
Put some limits to avoid that.