[ci] Windows: Add appropriate flags to compile with CUDA < 12.1 #1754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `--allow-unsupported-compiler` and `ALLOW_COMPILER_AND_STL_VERSION_MISMATCH` flags to prevent fatal errors induced by the version of the MSVC compiler, which has been updated in the GitHub image to a recent version that by default does not support any version of CUDA that is below 12.1.
cbentejac
force-pushed
the
ci/fixWindows
branch
from
50b37fe to
6f5dcd4
Compare
The `ALICEVISION_BUILD_EXAMPLES` flag has been removed when the samples have been removed from the project, it is thus useless to keep any reference to it.
cbentejac
force-pushed
the
ci/fixWindows
branch
from
6f5dcd4 to
318574f
Compare
servantftransperfect
approved these changes
Oct 7, 2024
Contributor
servantftransperfect
left a comment
servantftransperfect
left a comment
There was a problem hiding this comment.
Perfect, _ALLOW_COMPILER_AND_STL_VERSION_MISMATCH would frighten me, but scoped to continuous integration seems ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Windows build of AliceVision in the GitHub's workflow. Following an update of the image, the MSVC compiler's version was too recent to support by default the compilation of projects using a version of CUDA below 12.1.
Flags to bypass the fatal checks and go through with the compilation have been added.
Additionally, all references to the build flag
ALICEVISION_BUILD_EXAMPLEShave been removed, as the flag itself has been removed from the project at the same time as the samples.