[src] Comply with nanoflann >= 1.6.0 changes #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 27, 2025
servantftransperfect
approved these changes
Feb 27, 2025
cbentejac
force-pushed
the
build/nanoflann
branch
from
e41c71a to
94cd032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds implements the necessary changes for AliceVision to keep compiling with nanoflann 1.6.0 and over. Although AliceVision currently uses an older version of nanoflann that does not require these changes to compile, including them now does not cause any change in the behaviour and will allow a smoother upgrade.
Changes were flagged by @dkogan in #1813 and #1833.