[blender] Fix .obj import for blender 4 #1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the .obj import call in loadModel to use the new Blender 4 operator, ensuring compatibility across Blender 3 and 4.
- Replaces deprecated
bpy.ops.import_scene.objwithbpy.ops.wm.obj_import - Adjusts axis parameter names to match the new API
Comments suppressed due to low confidence (1)
meshroom/blender/scripts/preview.py:216
- [nitpick] The docstring mentions "Alembic of OBJ format", which can be confusing. Consider splitting into two cases or clarifying that this function handles both .abc and .obj formats.
'''Load model in Alembic of OBJ format. Make sure orientation matches camera orientation.'''
CedricThebault
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the method for importing
.objfiles in theloadModelfunction to align with changes in Blender's API. The key change replaces the deprecatedbpy.ops.import_scene.objoperator with thebpy.ops.wm.obj_importoperator. This ensures compatibility with older and newer versions of Blender. (versions 3 and 4)