Skip to content

Conversation

@servantftransperfect
Copy link
Contributor

@servantftransperfect servantftransperfect commented Jul 17, 2025

This pull request introduces two key updates to the pyalicevision codebase: enforcing a specific module loading order in __init__.py and updating SWIG module declarations across multiple files to use the package directive instead of module. These changes improve module organization and compatibility with Python packaging standards.

Module Loading Order:

  • Updated src/aliceVision/__init__.py to enforce a specific loading order by explicitly importing geometry, sfmData, and sfmDataIO modules. This ensures dependencies are loaded in the correct sequence.

SWIG Module Declaration Updates:

  • Replaced %module (module="pyalicevision") with %module (package="pyalicevision") in the following files to align with Python package standards:
    • src/aliceVision/camera/Camera.i
    • src/aliceVision/feature/feature.i
    • src/aliceVision/geometry/Geometry.i
    • src/aliceVision/hdr/Hdr.i
    • src/aliceVision/image/image.i
    • src/aliceVision/matching/matching.i
    • src/aliceVision/matchingImageCollection/matchingImageCollection.i
    • src/aliceVision/numeric/numeric.i
    • src/aliceVision/sensorDB/SensorDB.i
    • src/aliceVision/sfmData/SfMData.i
    • src/aliceVision/sfmDataIO/SfMDataIO.i
    • src/aliceVision/stl/Stl.i
    • src/aliceVision/track/track.i

Dependency Import:

  • Added %import <aliceVision/geometry/Pose3.i> in src/aliceVision/sfmData/CameraPose.i to ensure required dependencies are explicitly imported.

@servantftransperfect servantftransperfect added this to the 3.3.0 milestone Jul 17, 2025
@servantftransperfect servantftransperfect marked this pull request as draft July 17, 2025 07:19
@servantftransperfect servantftransperfect changed the title [SWIG] Better modules type sharing Improve SWIG Module Type Sharing for Enhanced Interoperability Jul 17, 2025
@servantftransperfect servantftransperfect marked this pull request as ready for review July 17, 2025 12:05
@cbentejac cbentejac merged commit 5e40d9f into develop Jul 17, 2025
4 checks passed
@cbentejac cbentejac deleted the dev/swigShared branch July 17, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants