Skip to content

fix hidden path issue#118

Merged
alirezanet merged 1 commit intoalirezanet:masterfrom
deler-aziz:master
Aug 13, 2024
Merged

fix hidden path issue#118
alirezanet merged 1 commit intoalirezanet:masterfrom
deler-aziz:master

Conversation

@deler-aziz
Copy link
Copy Markdown
Contributor

Description

Please check #117

Fixes #117

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • I did test corresponding changes on Windows
  • I did test corresponding changes on Linux
  • I did test corresponding changes on Mac

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Aug 12, 2024

PR Summary

  • Improved Configuration Loading Mechanism
    The PR introduces a more efficient method for loading configurations in the HuskyTaskLoader.cs component. We have adopted a strategy that employs a PhysicalFileProvider, aiming at an exact file named "task-runner.json". This change simplifies the process and can potentially improve the system's overall performance as it can find and load the necessary configurations more quickly and accurately.

Copy link
Copy Markdown
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! LGTM 👌💐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Husky fails to load task-runner.json

2 participants