export clock method to allow assignable in other packages#242
Merged
siennathesane merged 1 commit intoallegro:masterfrom Sep 17, 2020
Merged
export clock method to allow assignable in other packages#242siennathesane merged 1 commit intoallegro:masterfrom
siennathesane merged 1 commit intoallegro:masterfrom
Conversation
For example:
```
cache := bigcache.NewBigCache(bigcache.DefaultConfig(time.Minute))
clock := &mockedClock{}
rf := reflect.ValueOf(cache).Elem().FieldByName("clock")
reflect.NewAt(rf.Type(), unsafe.Pointer(rf.UnsafeAddr())).Elem().Set(reflect.ValueOf(clock))
```
Without this change, it panics with `value of type *cache_test.mockedClock is not assignable to type bigcache.clock`
And it goes to `*cache_test.mockedClock cannot implement bigcache.Clock as it has a non-exported method and is defined in a difference package`
if we only export clock interface.
janisz
approved these changes
Sep 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
Without this change, it panics with
value of type *cache_test.mockedClock is not assignable to type bigcache.clockAnd it goes to
*cache_test.mockedClock cannot implement bigcache.Clock as it has a non-exported method and is defined in a difference packageif we only export clock interface.Fix #241