Skip to content

No need to del elem when config.CleanWindow>0 at method:Set#325

Merged
cristaloleg merged 2 commits intoallegro:masterfrom
zhangyaping-CN:fix/cache_set
Aug 2, 2022
Merged

No need to del elem when config.CleanWindow>0 at method:Set#325
cristaloleg merged 2 commits intoallegro:masterfrom
zhangyaping-CN:fix/cache_set

Conversation

@zhangyaping-CN
Copy link
Contributor

No description provided.

Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, maybe a test?

Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (7c2932e) to head (3a94d94).

Files with missing lines Patch % Lines
shard.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   88.73%   87.50%   -1.24%     
==========================================
  Files          15       15              
  Lines         772      776       +4     
==========================================
- Hits          685      679       -6     
- Misses         73       80       +7     
- Partials       14       17       +3     
Files with missing lines Coverage Δ
shard.go 84.16% <40.00%> (-3.68%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2932e...3a94d94. Read the comment docs.

@cristaloleg cristaloleg merged commit 8f80589 into allegro:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants