Conversation
2015aroras
approved these changes
Mar 26, 2024
Collaborator
2015aroras
left a comment
2015aroras
left a comment
There was a problem hiding this comment.
LGTM! It's nice to see OLMo even easier to use.
nit: Can you remove/update the "Once you've updated the data paths in the config..." part of the README?
configs/official/OLMo-1B.yaml
Outdated
| datasets: | ||
| v3-small-c4_en-validation: | ||
| - r2://olmo-data/eval-data/perplexity/v3_small_gptneox20b/c4_en/val/part-0-00000.npy | ||
| - http://olmo-data.org/eval-data/perplexity/v3_small_gptneox20b/c4_en/val/part-0-00000.npy |
Collaborator
There was a problem hiding this comment.
Just curious, any reason for http instead of https?
epwalsh
approved these changes
Mar 27, 2024
Member
epwalsh
left a comment
epwalsh
left a comment
There was a problem hiding this comment.
LGTM, also just curious why HTTP and not HTTPS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not fast like this, because we make a lot of small range requests per batch, but it works.