Adds a new experimental sharded checkpointer from OLMo-core#532
Merged
Adds a new experimental sharded checkpointer from OLMo-core#532
Conversation
dirkgr
approved these changes
Apr 2, 2024
Member
dirkgr
left a comment
dirkgr
left a comment
There was a problem hiding this comment.
By itself, this seems good. The main question is, is olmo-core ready for prime-time?
Member
Author
Probably not, but this will be a good stress test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works a lot like the "torch_new" checkpointer where each rank only downloads the exact amount of data it needs and you can load a checkpoint with a different distributed topology, but without the additional GPU memory overhead.
For now we'll have to rely on installing the OLMo-core package directly from GitHub.