Merged
Conversation
2015aroras
changed the title
dirkgr
approved these changes
Apr 2, 2024
Member
dirkgr
left a comment
dirkgr
left a comment
There was a problem hiding this comment.
Surprised this doesn't fail some check for an unused parameter?
Collaborator
Author
It causes a linting warning. It can be valid when implementing an inherited method without needing all the parameters. I assume this is why it doesn't cause an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading to transformers 4.39.1 caused a HF pipeline test to start failing (e.g. https://github.com/allenai/OLMo/actions/runs/8444118035/job/23129075811). The issue is a HF bug (huggingface/transformers#29426) and this is a workaround to get around the problem.