Skip to content

Comments

Hybrid sharding with specific number of replicas#540

Merged
2015aroras merged 5 commits intomainfrom
shanea/hybrid-sharding-num-groups-2
Apr 17, 2024
Merged

Hybrid sharding with specific number of replicas#540
2015aroras merged 5 commits intomainfrom
shanea/hybrid-sharding-num-groups-2

Conversation

@2015aroras
Copy link
Collaborator

Adds the ability to specify the number of model instances when using a hybrid sharding strategy. If the number of instances is less than the number of nodes, multiple nodes will be used per instance.

@epwalsh
Copy link
Member

epwalsh commented Apr 15, 2024

@2015aroras can we get this merged? Then I'll follow up with another PR for the optimizer stuff

@2015aroras 2015aroras marked this pull request as ready for review April 15, 2024 17:47
@2015aroras 2015aroras requested a review from epwalsh April 15, 2024 17:48
@2015aroras 2015aroras merged commit 4ed135e into main Apr 17, 2024
@2015aroras 2015aroras deleted the shanea/hybrid-sharding-num-groups-2 branch April 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants