Merged
Conversation
epwalsh
reviewed
May 30, 2024
Member
epwalsh
left a comment
epwalsh
left a comment
There was a problem hiding this comment.
@ananyahjha93 please don't merge anything into main without a review. This PR touches some critical components and I'm pretty sure your changes will force an unnecessary host device sync on every batch, which could potentially have a big negative impact on training throughput.
Comment on lines
-214
to
+222
| group, max_norm_ratio, global_step, all_metrics, collect_param_metrics=collect_param_metrics | ||
| group, max_norm_ratio, global_step, all_metrics, collect_param_metrics=True |
Member
There was a problem hiding this comment.
Why this change? This will force a host device sync on every batch.
Contributor
Author
There was a problem hiding this comment.
let me send in a PR for this fix!
Comment on lines
-218
to
+226
| group, max_norm, all_metrics, collect_param_metrics=collect_param_metrics | ||
| group, max_norm, all_metrics, collect_param_metrics=True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests (CPU and GPU) to compare torch clipping and olmo clipping and fixed clipping for DDP and FSDP no_shard
@epwalsh can we merge this PR so that I can push the DDP one after this?