Conversation
AkshitaB
left a comment
AkshitaB
left a comment
There was a problem hiding this comment.
Minor suggestion: it will be great if it takes in https paths that we directly copy from the browser, and processes the strings to remove them to pass to the api.run command. A bit quicker for the user.
scripts/compare_wandb_configs.py
Outdated
|
|
||
|
|
||
| def flatten(dictionary, parent_key="", separator="."): | ||
| items = [] |
There was a problem hiding this comment.
Just curious, why not use a dictionary and dict.update(...) instead of a list with extend()?
There was a problem hiding this comment.
Because I copy and pasted this from SO 🙈.
Fixed in 049969b.
| } | ||
| if len(keys_with_differences) > 0: | ||
| if len(left_only_keys) > 0 or len(right_only_keys) > 0: | ||
| print("Settings with differences:") |
There was a problem hiding this comment.
Having this in an if statement is a bit odd, but I guess you prefer it that way?
There was a problem hiding this comment.
It prints this heading if it already printed other headings. Otherwise, there is only one heading, which we don't really need.
3 participants
No description provided.