Merged
Conversation
epwalsh
approved these changes
Aug 14, 2024
Member
epwalsh
left a comment
epwalsh
left a comment
There was a problem hiding this comment.
Can you add a module docstring to the top of the script explaining what it does exactly? Otherwise LGTM.
This helped reveal that one of the LUMI containers was not loading/saving checkpoints correctly.
Did you get to the bottom of this? What exactly was the issue and the fix?
Collaborator
Author
Honestly, no idea what was causing the issue. The issue was in LUMI's provided EasyBuild container but not in any of the containers we made, so I just scrapped the idea of using LUMI's provided container. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a script for comparing model state of 2 different OLMo models/checkpoints. This helped reveal that one of the LUMI containers was not loading/saving checkpoints correctly.