Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ All notable changes to this project will be documented in this file.
- Add deprecation warning to `finetune.py` pointing users to the OLMo-core SFT implementation (https://github.com/allenai/open-instruct/pull/1574).

### Fixed
- Reduce repeated low disk space send-alert warnings so each run only alerts once per checkpoint path (https://github.com/allenai/open-instruct/pull/1608).
- Fix `Batch.__getitem__` handling of `active_tools` for int and list indexing (https://github.com/allenai/open-instruct/pull/1592).
- Fix `RepeatPhraseChecker.check_following` to validate all matched phrases differ by exactly one word and return a proper boolean instead of `None` (https://github.com/allenai/open-instruct/pull/1044).
- Fix incorrect hardcoded checkpoint state path for multi-GPU DeepSpeed resumption (https://github.com/allenai/open-instruct/pull/1589).
Expand Down
5 changes: 4 additions & 1 deletion open_instruct/grpo_fast.py
Original file line number Diff line number Diff line change
Expand Up @@ -1994,6 +1994,7 @@ def health_check_fn():
wandb_url=wandb_url,
)
last_eval_collected = True
has_warned_about_checkpoint_disk_space = False
for training_step in range(resume_training_step, args.num_training_steps + 1):
start_time = time.perf_counter()

Expand Down Expand Up @@ -2062,7 +2063,9 @@ def health_check_fn():
and training_step % args.checkpoint_state_freq == 0
and args.checkpoint_state_dir is not None
):
utils.warn_if_low_disk_space(args.checkpoint_state_dir, send_slack_alerts=args.send_slack_alerts)
if not has_warned_about_checkpoint_disk_space:
utils.warn_if_low_disk_space(args.checkpoint_state_dir, send_slack_alerts=args.send_slack_alerts)
has_warned_about_checkpoint_disk_space = True
with Timer("[Main Thread] 🗡️ Saving checkpoint state"):
# Save comprehensive client state including dataloader state
client_state = {
Expand Down
Loading