Fix tests running against GOV.UK Frontend 6.0.0#2504
Merged
romaricpascal merged 4 commits intomainfrom Feb 12, 2026
Merged
Conversation
This is more robust to changes of semantics in the GOV.UK Footer component, like the one introduced by GOV.UK Frontend v6.0.0.
6a36e1b to
05f9dc1
Compare
mainVariables for applied colours no longer configure GOV.UK Frontend, instead us `$govuk-functional-colour`
9deca45 to
6d67ec1
Compare
This plugin is not compatible with the version of GOV.UK Frontend installed by default when creating new prototypes, which makes the test fail not because their actions fail, but because they can't be set up as intended. The amount of work to untangle this is non-trivial and the features were working manually. Co-authored-by: Oliver Byford <oliver.byford@digital.cabinet-office.gov.uk>
6d67ec1 to
803ec49
Compare
domoscargin
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the Prototype Kit installs the latest version of GOV.UK Frontend, tests now run against GOV.UK Frontend v6.0.0.
Some test expectations look at the colours in the built CSS and other compile the step-by-step plugin, which uses the
$legacyparameter ofgovuk-colour.I pushed two commits that fix the selector for grabbing items in the GOV.UK Footer, as well as the selector for changing the header's colour.
Tests remain failing until a new version of the step-by-step plugin is released, as the plugin uses the
$legacyparameter.