Handle cases where information on attachments is missing or faulty#344
Open
Thaodan wants to merge 2 commits intoalphapapa:masterfrom
Open
Handle cases where information on attachments is missing or faulty#344Thaodan wants to merge 2 commits intoalphapapa:masterfrom
Thaodan wants to merge 2 commits intoalphapapa:masterfrom
Conversation
Some bridges for example seem to return videos/audio-messages without a size just with a duration. Fixes alphapapa#340.
…ation Handle error cases where false data has been send i.e. as if a sender sends a file that was corrupted because of technical bugs on their side or simple is empty. I.e. an audio messages was send but without audio recorded.
Thaodan
force-pushed
the
ement_room_size_zero_duration
branch
from
1377473 to
c424dee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some bridges for example seem to return videos/audio-messages without a size just with a duration.
Similarly a faulty media file might be returned without a duration at all, this PR makes that Ement handles these
case gracefully.