Feature/awscliv2

[Orachigami]

Replaced aws-cli v1 with aws-cli v2.
aws-cli v2.1.39 is compatible with gcompat + groff

aws/aws-cli#4685

[ozbillwang]

that's great. Let me review.

In fact, I worked on this feature before via

#10

#9

but can't work it out at that time.

[ozbillwang]

I'd like to keep both versions, I explained it in #10

We need keep compatible in this image.

• install both aws cli v1 and v2 in same image
• set ENTRYPOINT to switch default aws cli version when run the container.
  • if environment variable awscli is set to v2, default aws cli version is v2
  • if environment variable awscli is set to v1, not set or set to anything else, except v2, aws cli will be run from /usr/bin, and version is v1
• you can still run specific version with full path in container.

$ docker build -t k8s .
$ docker run -ti --rm -e awscli=v2 k8s aws --version
aws-cli/2.1.22 Python/3.7.3 Linux/4.19.121-linuxkit exe/x86_64.alpine.3 prompt/off
$ docker run -ti --rm -e awscli=v1 k8s aws --version
aws-cli/1.18.223 Python/3.8.7 Linux/4.19.121-linuxkit botocore/1.19.63
$ docker run -ti --rm k8s --version
aws-cli/1.18.223 Python/3.8.7 Linux/4.19.121-linuxkit botocore/1.19.63

can you adjust your codes to keep both versions?

[Orachigami]

@ozbillwang added entrypoint script, results here:

$ docker build -t k8s .
$ docker run -ti --rm -e awscli=v2 k8s aws --version
aws-cli/2.1.39 Python/3.8.8 Linux/5.10.76-linuxkit exe/x86_64.alpine.3 prompt/off
$ docker run -ti --rm k8s aws --version
aws-cli/1.22.96 Python/3.9.7 Linux/5.10.76-linuxkit botocore/1.24.41
$ docker run -ti --rm -e awscli=100500 k8s aws --version
aws-cli/1.22.96 Python/3.9.7 Linux/5.10.76-linuxkit botocore/1.24.41

I reread your message and reverted aws iam authenticator to Dockerfile for compatibility

[Orachigami]

@ozbillwang, shall I make any other changes for this image?

[yi-yang-github]

how can I use / test this? I am using AWS v2 and I can't get helm work on a k8s 1.22 cluster (AWS EKS). Wondering is it because AWS v1 is not supported anymore.

Also the latest AWS v2 seems to be aws-cli/2.4.5.

[yi-yang-github]

also maybe need to specify kubectl version (1.23.6) instead of latest
actions/runner-images#5493 (comment)

[ozbillwang]

@Orachigami

So should we lock the aws v2 version in Dockerfile, or we can always install the latest version? I put the comments before.

[Orachigami]

@ozbillwang have you checked this comment?
#31 (comment)

[ozbillwang]

oh, I missed that comment, let me check

[bombergio]

Is this PR abandoned, and is it missing something?

[Orachigami]

Is this PR abandoned, and is it missing something?

Kinda abandoned I suppose 😃

If all packages are still available then it still should work

[romanfurst]

Is there any chance this pull request will be merged? If someone refresh the changes, ensures everything is up-to-date, and confirms that it works well, could it be processed?
Or is there any major reason why AWS CLI v2 is not being supported?

[clayrosenthal]

Took a crack in #79, using a separate script I copy into the image at /usr/local/bin/aws rather than an entrypoint, should allow any tool to use it