Skip to content

Update regression metrics to handle multiseries problems#4233

Merged
eccabay merged 7 commits intomainfrom
4231_msts_metrics
Jul 12, 2023
Merged

Update regression metrics to handle multiseries problems#4233
eccabay merged 7 commits intomainfrom
4231_msts_metrics

Conversation

@eccabay
Copy link
Copy Markdown
Contributor

@eccabay eccabay commented Jul 12, 2023

Closes #4231

Our anticipated input from users for multiseries problems has one column that contains all the series targets and one column that delineates the series_id of each row. However, our estimators expect one column per series, so we will be internally converting between these two forms.

Both scikit-learn and sktime already have implementations for multioutput problems expecting the "one column per series" data format, so this PR assumes that input format as well, and just adapts the few metrics that were not already set up to handle this.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 12, 2023

Codecov Report

Merging #4233 (3a79e83) into main (aa17295) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4233     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      38284   38314     +30     
=======================================
+ Hits       38165   38195     +30     
  Misses       119     119             
Impacted Files Coverage Δ
evalml/objectives/objective_base.py 100.0% <100.0%> (ø)
evalml/objectives/standard_metrics.py 100.0% <100.0%> (ø)
...lml/tests/objective_tests/test_standard_metrics.py 100.0% <100.0%> (ø)

@eccabay eccabay marked this pull request as ready for review July 12, 2023 14:56
Copy link
Copy Markdown
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good work!

Copy link
Copy Markdown
Contributor

@christopherbunn christopherbunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eccabay eccabay merged commit 695b5ec into main Jul 12, 2023
@eccabay eccabay deleted the 4231_msts_metrics branch July 12, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure that time series regression metrics support MS

3 participants