Fix deps checker including any package with post in the name#4268
Merged
christopherbunn merged 4 commits intomainfrom Aug 10, 2023
Merged
Fix deps checker including any package with post in the name#4268christopherbunn merged 4 commits intomainfrom
post in the name#4268christopherbunn merged 4 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4268 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 355 355
Lines 38915 38915
=====================================
Hits 38794 38794
Misses 121 121 |
christopherbunn
requested review from
MichaelFu512,
chukarsten,
eccabay,
fjlanasa,
jeremyliweishih and
remyogasawara
eccabay
reviewed
Aug 10, 2023
christopherbunn
commented
Aug 10, 2023
| @@ -1,4 +1,4 @@ | |||
| reqs_list=$(python -c "import os; from evalml.utils import get_evalml_pip_requirements; print('\n'.join(get_evalml_pip_requirements(os.getcwd())))") | |||
| allow_list=$(echo ${reqs_list} | grep -oE "[a-zA-Z]+[a-zA-Z_\-]*" | paste -d "|" -s -) | |||
| allow_list=$(echo ${reqs_list} | grep -oE "[a-zA-Z]+[a-zA-Z_\-]*" | grep -v "post" | tr "_" "-" | paste -d "|" -s -) | |||
Contributor
Author
There was a problem hiding this comment.
Added tr to replace underscores with hyphens since pip does that automatically apparently
christopherbunn
force-pushed
the
fix_deps_checker
branch
from
c88e7dd to
853d92d
Compare
MichaelFu512
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with our automated dependency checker where we are including any package with
postin the name/version number.Resolves #4269