Pin pandas version#4315
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4315 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 357 357
Lines 39767 39767
=====================================
Hits 39647 39647
Misses 120 120 ☔ View full report in Codecov by Sentry. |
eccabay
requested review from
MichaelFu512,
christopherbunn and
jeremyliweishih
christopherbunn
left a comment
christopherbunn
left a comment
There was a problem hiding this comment.
One question but otherwise LGTM
| - python_version: "3.9" | ||
| command: 'git-test-automl' |
There was a problem hiding this comment.
Do we need to test on 3.9? If so, should we just bump up the Python versions to 3.9 across all tests?
There was a problem hiding this comment.
Testing on 3.9 is how we can double check that the pinning worked, since pandas 2.1.0 isn't installed on 3.8. I don't think we should just immediately bump everything up, but I do agree that arbitrarily just running git-test-automl for 3.9 and not the others doesn't make much sense.
Thoughts on testing 3.9 alongside 3.8 for all PR tests? I don't think it'll add any time, since the tests all run in parallel
There was a problem hiding this comment.
I think adding one additional test for 3.9 is sufficient.
| - python_version: "3.9" | ||
| command: 'git-test-automl' |
There was a problem hiding this comment.
I think adding one additional test for 3.9 is sufficient.
3 participants
Closes #4313